[ChicletPrime]

okay, we're done for the mo'. 291 screenshots are now loaded into the front page rotation so that should hold us for a little bit.

[Coldsaturn]

Obsessed with the color of the titles and some main buttons. That dirty pink is doing things to my eyes.

[ChicletPrime]

PaleVioletRed charges to the fore!

I am considering a slightly paler pink, maybe heading a little more towards coral? decisions, decisions. This time around I actually annotated the code so sweet jebus, maybe it'll be easier to find what controls the headers next time. It was an adventure and a half of spelunking let me tell you, which is why it took me two weeks to get back to it.

Maybe I should just change the header to that brighter pink.

We are now 412 screenshots for the rotating front page.

[ChicletPrime]

just a little update that the front page rotation images are now at 570. nice.

[Coldsaturn]

How do we feel about tiktok embeds? I was thinking about sharing a few nice edits, but there's no direct way of doing that on mybb. I found a workaround on this page https://community.mybb.com/thread-234597.html but I don't know if you'd be interested in that. I can always just link the video instead of embedding it if I need to.

[ChicletPrime]

we feel fine about it, i am down for anything that needs me to spleunk code as i am just that sort of geek. let me look at your hack that you found and I'll see if I can get it to work here.

[ChicletPrime]

Code:

[tiktok] the url here [/tiktok]

okay, try it i guess? see if it works.

[Coldsaturn]

It works! <3
It only allows 1 embed per post though, so there's a risk of spamming messages like with youtube videos before you allowed multiples in one single post

[ChicletPrime]

i don't know what the issue is with it only allowing one "embed" of this new tiktok code - as far as I can tell, it ought to work with multiples? but its not so this is going to require a bunch of digging and there may not be an answer.

I guess for the moment, please don't spam the board with 50 tiktok messages inside of 2 minutes or whatever the lock out is. as this is a custom thing using somebody's custom written code, this isn't a toggle inside the master code that just needs switching (like the youtube thing which did have a specific allowance number which just needed overriding).

[Coldsaturn]

Ok tried again and indeed if I put one video it shows up, but if it's two the post automatically goes blank. I went on a research tangent to understand the problem, and it seems that the issue is with the code which would parse anything between [tiktok] and [/tiktok], and if one puts more than one embed, it will only read the first tag and the closing tag at the end of the entire list swallowing all the urls inside in one single mess. This is specifically a problem with greedy regex .+) or .*)

Possible solutions:
1) Use the first option in the link, which offered a non-greedy regex

Code:

Regular Expression
\[tiktok\](.*?)\[\/tiktok\]

Replacement
<iframe width="560" height="750" src="https://www.tiktok.com/embed/v2/$1" frameborder="0" allowfullscreen></iframe>

But it's still susceptible to possible human error if the url contains spaces or newlines etc.

2) This option will force the parsing of the numerical sequence in the url exclusively (the video ID), which should avoid problems with possible typing mistakes

Code:

Regular Expression
\[tiktok\]\s*([0-9]{8,})\s*\[\/tiktok\]

Replacement
<iframe width="560" height="750" src="https://www.tiktok.com/embed/v2/$1" frameborder="0" allowfullscreen></iframe>

In both cases what is needed is just the video ID (the numbers at the end of the url)